-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK-548] NLP add rtl script support #4904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! I have a functional question about the Django templates, but it's not a blocker - the addition seems benign, just not sure what it's doing.
kpi/templates/base_simple.html
Outdated
@@ -2,7 +2,7 @@ | |||
|
|||
{% load static %} | |||
<!doctype html> | |||
<html> | |||
<html dir="auto"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this line do anything? As you noted in the PR description, dir="auto"
doesn't appear to transfer down to child elements. I can't find a difference on /accounts/login/
- the layout, text direction, and input text direction appear to all stay the same as on beta
, whether using an RTL or LTR language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that although it doesn't transfer down, it does something sometimes :P I tried to find any documentation or SO question that would confirm that, but there is nothing. I removed it
Checklist
Description
Any transcript or translation text written in RTL script will be displayed correctly.
Notes
The
dir='auto'
attribute is magically doing all the job. I thought there would be a way to set it as default for every HTML node, but it doesn't seem to work. Adding it to each node with RTL text does the job.